Seed zero-value metrics for empty buckets in count-items#378
Open
delthas wants to merge 1 commit into
Open
Conversation
Contributor
Hello delthas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development/1 #378 +/- ##
=================================================
+ Coverage 45.47% 45.64% +0.17%
=================================================
Files 88 88
Lines 6529 6546 +17
Branches 1372 1376 +4
=================================================
+ Hits 2969 2988 +19
+ Misses 3510 3508 -2
Partials 50 50 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
delthas
changed the title
Contributor
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
delthas
force-pushed
the
improvement/S3UTILS-224/preseed-empty-bucket-metrics
branch
from
c954e09 to
ef5a150
Compare
delthas
changed the title
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
|
LGTM |
delthas
force-pushed
the
improvement/S3UTILS-224/preseed-empty-bucket-metrics
branch
from
ef5a150 to
6442f99
Compare
DarkIsDude
reviewed
Jul 8, 2026
benzekrimaha
reviewed
Jul 8, 2026
benzekrimaha
reviewed
Jul 8, 2026
count-items only produced metric documents for buckets that hold objects. An empty bucket yielded no document in __infostore, which makes Scuba's deep health check fail and disables the quota service cluster-wide (ARTESCA-17063). Seed zero-value bucket, account and location entries in getObjectMDStats() when a bucket scan yields no objects. The bucket key is derived from the __usersbucket creation date, exactly like populated buckets (S3UTILS-131), so the seeded document matches the key quota lookups use; if that date is missing the bucket is skipped with a warning rather than written under an unmatchable key. Issue: S3UTILS-224
delthas
force-pushed
the
improvement/S3UTILS-224/preseed-empty-bucket-metrics
branch
from
6442f99 to
cf6258d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
count-items only produced metric documents for buckets that hold objects. An empty bucket yielded no document in
__infostore, so Scuba's deep health check (getAnyMetric) found nothing and returned 500, causing CloudServer to disable the quota service cluster-wide (ARTESCA-17063).This seeds zero-value entries for the empty bucket, its account and its location in
getObjectMDStats()when a bucket scan yields no objects, so every known resource always has a document in__infostore.The bucket key is derived from the
__usersbucketcreation date, exactly like populated buckets (S3UTILS-131), so the seeded document matches the key quota lookups use. If that date is missing, the bucket is skipped with a warning rather than written under a key that lookups could never match.Note: this addresses only the empty-bucket case. The new-bucket window (before the first count-items run) and the Scuba deep-health-check / alert behavior are tracked separately.
Issue: S3UTILS-224